Skip to content

Commit

Permalink
Run tests on PRs
Browse files Browse the repository at this point in the history
  • Loading branch information
dgirardi committed Sep 8, 2022
1 parent d25cbfd commit f57ab3c
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
docker:
# specify the version you desire here
- image: circleci/node:8.9.0

# Specify service dependencies here if necessary
# CircleCI maintains a library of pre-built images
# documented at https://circleci.com/docs/2.0/circleci-images/
Expand Down Expand Up @@ -45,6 +45,6 @@ jobs:
# Run the file with user's access key
./BrowserStackLocal ${BROWSERSTACK_ACCESS_KEY} &
# run tests!
- run:
- run:
name: BrowserStack testing
command: gulp test --browserstack
2 changes: 1 addition & 1 deletion src/nativeAssetManager.js
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ export function newNativeAssetManager(win, pubUrl) {
}

function placeholderFor(key, adId) {
return (adId && !hasPbNativeData()) ? `${key}:${adId}` : ((hasPbNativeData()) ? '##'+`${key}`+'##' : `${key}`)
return (adId && !hasPbNativeData()) ? `${key}:${adId}` : ((hasPbNativeData()) ? `##${key}##` : key)
}

function scanForPlaceHolders(adId, ...markupFragments) {
Expand Down

0 comments on commit f57ab3c

Please # to comment.