First commit #1
First commit #1
Conversation
| @@ -0,0 +1,8 @@ | |||
| { | |||
| "presets": ["env"], | |||
There was a problem hiding this comment.
from the docs: babel-preset-env behaves exactly the same as babel-preset-latest (or babel-preset-es2015, babel-preset-es2016, and babel-preset-es2017 together).
Is this what we want?
There was a problem hiding this comment.
They have deprecated babel-preset-es2015 and advised to use babel-preset-env
There was a problem hiding this comment.
ok but what's that do to the file size?
| }); | ||
|
|
||
| gulp.task('build-prod', ['clean'], () => { | ||
| var cloned = _.cloneDeep(webpackConfig); |
There was a problem hiding this comment.
why do you need to clone this?
There was a problem hiding this comment.
For prod we remove source-maps from webpack config. So we clone the object and do not modify original webpack config.
package.json
Outdated
| "name": "prebid-universal-creative", | ||
| "version": "0.1.0", | ||
| "description": "", | ||
| "main": "index.js", |
There was a problem hiding this comment.
this should be dist/creative.js I think
src/creative.js
Outdated
| /** | ||
| * @param {object} doc | ||
| * @param {string} adId | ||
| * @param {object} dataObject |
There was a problem hiding this comment.
let's break out the jsDoc for dataObject
src/creative.js
Outdated
| } else if (environment.isCrossDomain()) { | ||
| renderCrossDomain(adId, dataObject.pubUrl); | ||
| } else { | ||
| // assume legacy? |
src/creative.js
Outdated
| utils.sendRequest(adUrl, handler); | ||
| } | ||
|
|
||
| // function render() { |
src/environment.js
Outdated
| /** | ||
| * @returns true if we are running on the top window at dispatch time | ||
| */ | ||
| function isCodeOnPage() { |
There was a problem hiding this comment.
rename to something like isTopWindow
| * Return true if we are in an iframe and can't access the top window. | ||
| */ | ||
| export function isCrossDomain() { | ||
| return window.top !== window && !window.frameElement; |
There was a problem hiding this comment.
does this throw an exception?
There was a problem hiding this comment.
No it won't throw exception.
src/environment.js
Outdated
| /** | ||
| * Return true if we cannot document.write to a child iframe (this implies no allow-same-origin) | ||
| */ | ||
| function isSuperSandboxedIframe() { |
src/utils.js
Outdated
|
|
||
| var escapedUrl = encodeURI(url); | ||
| var img = '<div style="position:absolute;left:0px;top:0px;visibility:hidden;">'; | ||
| img += '<img src="' + escapedUrl + '"></div>'; |
There was a problem hiding this comment.
could use string templates here
|
@mkendall07 Updated the code. We can merge this one and create separate PR for adding test framework. |
First commit.