Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Amp resize #14

Merged
merged 5 commits into from
Mar 22, 2018
Merged

Amp resize #14

merged 5 commits into from
Mar 22, 2018

Conversation

jaiminpanchal27
Copy link
Collaborator

No description provided.

@bretg
Copy link
Contributor

bretg commented Mar 21, 2018

good stuff. To be clear, this isn't just for 1x1, it looks to resize the iframe to the chosen size regardless of the original size.

So it's also useful for multi-size ad units. e.g. 320x50 and 300x50

@jaiminpanchal27 jaiminpanchal27 changed the title Amp resize in case of 1x1 size Amp resize Mar 22, 2018
@mkendall07 mkendall07 merged commit 26465c3 into master Mar 22, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mkendall07 mkendall07 mkendall07 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaiminpanchal27 @bretg @mkendall07