Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add new tutorial: Two-scale composite laminate simulation with ABAQUS #412
base: develop
Are you sure you want to change the base?
Add new tutorial: Two-scale composite laminate simulation with ABAQUS #412
Changes from all commits
0436777
f414a5d
493c197
f2de90c
a8c12aa
0f780e1
60a737e
bbb3c71
4815933
a9cad1e
400a225
bc6ce10
be9250a
2e53836
0534b8f
25772a0
4aedd9e
54c7807
f3f3b10
04312de
4ebf1ea
15ecdd1
5a6789b
83dd8e4
5e8a910
80d05bd
fc1fcf7
66d37d7
575a875
374f9e3
2bffadc
43feb3e
b147e3f
1e394d5
c7ad963
5ef7bff
2f3b4a0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any information about how the mesh was generated? How was the case created?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not clear to me if this case should be in the tutorials, but I do understand it is an interesting study case for the PreECO project, where we want to establish such guidelines.
In my perspective, this case seems to be rather too specific to a setup, system, and solver, which makes it difficult to reuse. We can also not test it, since we don't have Abaqus licenses, so we will not be able to maintain or check it in the future, which is a promise we give for our tutorials.
It also seems to be an early prototype, as stated by the "currently simulations on both the scales are run in serial", from which I understand that this will be a validation case for your research.
We also have the Community projects section, which serves as a place to share cases that we don't promise to maintain.
What maintenance plan would you suggest? What do we need to maintain this case? Will you have access to the system and codes long-enough or easily on demand?
We have more ways to publish cases, we don't need that everything is in the tutorials. In my understanding, tutorials should be rather flexible, extensible, and reusable. They should be starting points. We do have old cases that could be improved in this direction, but I think that new cases should as much as possible be more flexible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the moment my standard answer would be: add now and potentially move somewhere else later once we have guidelines. This just forces us (i.e. @IshaanDesai ) to clean up and document such cases.
Maintaining should be doable as we now have access to Abaqus licenses in Stuttgart.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand the need and the impulse to "just add it to make people happy and move on", but as a reviewer, I am obliged to point out that
With the knowledge that we already got the PreECO project and that via that we have a "contract" to clean things up and come up with such guidelines, I don't mind accepting such a special case now.
That's good news! This case then could be a test case for integrating proprietary codes into our system tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we allowed to publish files generated by Abaqus? Does the Abaqus license specify what license is attached to these files? Is it compatible with our LGPL-3.0 license?
Maybe a better question: Can we automate (and parameterize) the generation of this file? What if I wanted to use a different mesh size?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to look up if Abaqus imposes a license on auto-generated input files, and there are no clear instructions. There are ample open-source repositories which directly upload Abaqus input files. This input file is actually usable via other FEM softwares too, for example, CalculiX. It is just generated by Abaqus.
Automation of the generation of this file could be possible, but I won't invest time in this. We get a fixed mesh here, for a different mesh size, one would have to go through the Abaqus GUI, load this file, change the mesh size, and generate another file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you then maybe document the steps to generate such a new mesh?