Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Revert #634 and update reference results #640

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

MakisH
Copy link
Member

@MakisH MakisH commented Mar 28, 2025

After releasing preCICE v3.2.0, we should update the reference results for the system tests and revert the changes introduced by #634. Besides the performance improvements we are missing, the configuration parameter <preconditioner update-on-threshold="<bool>" /> is not available pre-v3.2.0.

Checklist:

@MakisH MakisH self-assigned this Mar 28, 2025
@uekerman
Copy link
Member

If we touch this, I would suggest to directly switch to the default everywhere, e.g.

<acceleration:IQN-ILS>
  <data name="Displacement" mesh="Solid-Mesh" />
  <data name="Force" mesh="Solid-Mesh" />
</acceleration:IQN-ILS>

@uekerman uekerman mentioned this pull request Mar 31, 2025
73 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants