Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

♻️ improve QOL with mypy #120

Merged
merged 10 commits into from
Apr 23, 2024
Merged

♻️ improve QOL with mypy #120

merged 10 commits into from
Apr 23, 2024

Conversation

jvdd
Copy link
Member

@jvdd jvdd commented Apr 17, 2024

Closes #118

Copy link

codspeed-hq bot commented Apr 17, 2024

CodSpeed Performance Report

Merging #120 will degrade performances by 19.39%

Comparing mypy (d1e29a4) with main (e7890be)

Summary

⚡ 2 improvements
❌ 1 regressions
✅ 378 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main mypy Change
test_single_series_feature_collection_multiple_descriptors[1] 23,494.6 ms 441.7 ms ×53
test_single_series_feature_collection_multiple_descriptors[2] 1,254.1 ms 458.3 ms ×2.7
test_single_series_feature_collection_multiple_descriptors[4] 383.8 ms 476.1 ms -19.39%

@jonasvdd jonasvdd self-requested a review April 18, 2024 09:40
@jonasvdd jonasvdd self-assigned this Apr 18, 2024
Copy link
Member Author

@jvdd jvdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jvdd jvdd merged commit 322a975 into main Apr 23, 2024
21 of 22 checks passed
@jvdd jvdd deleted the mypy branch August 24, 2024 10:44
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check code with mypy
2 participants