🐛 check for None before setting n_jobs to nb logical CPUs
#126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasvdd
approved these changes
May 6, 2024
CodSpeed Performance ReportMerging #126 will degrade performances by 97.95%Comparing Summary
Benchmarks breakdown
|
|
The tsfel LPCC - bug - for which we provided a hotfix is fixed in https://github.com/fraunhoferportugal/tsfel/releases/tag/v0.1.4 |
|
Ready for review @jvdd! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the merger of #118 a bug slipped into tsflex.
Parsing the
n_jobsignored user-specified values (i.e. integers) and always selected the number of logical cores. As such, it was impossible for users to manage the number of jobs...