test: add online_tests feature to control Internet use
#2881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an `online_tests` feature that specifically covers tests accessing the Internet. It is enabled by default to preserve the existing behavior, but can be explicitly disabled when running the test suite entirely offline. I have not added the respective feature checks to `slow_integration_tests`, as they all seem to require Internet, so that seems redundant. Fixes prefix-dev#2880
baszalmstra
approved these changes
Jan 11, 2025
|
Thank you! |
|
Thanks! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an
online_testsfeature that specifically covers tests accessing the Internet. It is enabled by default to preserve the existing behavior, but can be explicitly disabled when running the test suite entirely offline.I have not added the respective feature checks to
slow_integration_tests, as they all seem to require Internet, so that seems redundant.Fixes #2880