Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add activate-environment option #108

Merged
merged 23 commits into from
May 11, 2024
Merged

Conversation

borchero
Copy link
Contributor

@borchero borchero commented May 10, 2024

@borchero borchero requested a review from pavelzw as a code owner May 10, 2024 19:10
@pavelzw
Copy link
Collaborator

pavelzw commented May 10, 2024

The no-lockfile and auth-Token-install failing tests are unrelated to this pr.

Copy link
Collaborator

@pavelzw pavelzw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the effort! Some comments

@pavelzw
Copy link
Collaborator

pavelzw commented May 10, 2024

Also, can you bump the version number to 0.7.0?

@pavelzw pavelzw added the enhancement New feature or request label May 10, 2024
@pavelzw
Copy link
Collaborator

pavelzw commented May 11, 2024

prefix-dev/pixi#1370

@pavelzw
Copy link
Collaborator

pavelzw commented May 11, 2024

I would prefer not adding -e default when it's also not being used in pixi install. Maybe we can reuse some logic from the install step.
image

@pavelzw
Copy link
Collaborator

pavelzw commented May 11, 2024

would be nice to remove the json block
image
is this possible in core.getExecOutput?

@borchero
Copy link
Contributor Author

is this possible in core.getExecOutput?

Yup, will do

@borchero borchero requested a review from pavelzw May 11, 2024 12:54
@pavelzw pavelzw merged commit d72307a into prefix-dev:main May 11, 2024
126 of 129 checks passed
@pavelzw
Copy link
Collaborator

pavelzw commented May 11, 2024

@borchero do you want to create a PR updating https://github.com/prefix-dev/pixi/blob/main/docs/advanced/github_actions.md or should i do that?

@borchero
Copy link
Contributor Author

Feel free to go ahead @pavelzw, I'd only get to it tonight 😅

@pavelzw
Copy link
Collaborator

pavelzw commented May 11, 2024

prefix-dev/pixi#1371

@borchero borchero deleted the activate-pixi branch May 21, 2024 08:06
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to use pixi-installed binaries without custom shell
2 participants