-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add better support for pyproject.toml pixi projects #87
Conversation
Hmm, i'm wondering whether we should make this behavior implicit without the need to specify |
I think we should, but we could make it a next step, just wanted to make sure there was an answer to the question on how to do it. |
src/options.ts
Outdated
if (existsSync('pixi.toml')) { | ||
manifestPath = 'pixi.toml' | ||
} else if (existsSync('pyproject.toml')) { | ||
manifestPath = 'pyproject.toml' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we validate the existance of a [tool.pixi]
table?
How do i trigger the full CI? 😅 |
Oeh I don't like to add a npm install to all these tests. You okay without reading the toml? @pavelzw |
Co-authored-by: Pavel Zwerschke <pavelzw@gmail.com>
Co-authored-by: Pavel Zwerschke <pavelzw@gmail.com>
@ruben-arts you need to force tsup to include Lines 15 to 23 in 4fc8d82
We should look how much larger the transpiled code will be; if it's too much we could also just read the file and check if |
Co-authored-by: Pavel Zwerschke <pavelzw@gmail.com>
The index.js has grown with 0.12 Mb. |
I think that's okay 👍🏻 |
Co-authored-by: Pavel Zwerschke <pavelzw@gmail.com>
Co-authored-by: Pavel Zwerschke <pavelzw@gmail.com>
@pavelzw This should be good now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than these comments it looks good.
Co-authored-by: Pavel Zwerschke <pavelzw@gmail.com>
Thanks for the support @pavelzw, learned a lot about action development! |
If updating documentation:
Fixes #88