Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Ignore more native gems when building gem #1872

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

presidentbeef
Copy link
Owner

No description provided.

Copy link

DryRun Security Summary

The changes in this pull request focus on optimizing the packaging of the Brakeman gem, a security analysis tool for Ruby on Rails applications, by excluding unnecessary files and directories, managing dependencies, and ensuring a clean build environment, which helps reduce the attack surface and maintain the reliability of the gem.

Expand for full summary

Summary:

The changes in this pull request are focused on optimizing the packaging of the Brakeman gem, which is a security analysis tool for Ruby on Rails applications. The main changes include excluding unnecessary files and directories from the gem package, managing dependencies, and ensuring a clean build environment. These changes are generally positive from a security perspective, as they help reduce the attack surface and maintain the reliability of the Brakeman gem.

The changes in the brakeman.gemspec file exclude certain directories and files from the gem package, which helps reduce the size of the gem and minimize the inclusion of unnecessary dependencies. The explicit addition of the racc gem as a dependency is also a common practice to ensure compatibility and reliability, especially when the gem has native code that cannot be easily bundled.

The changes in the build.rb file are focused on preparing a clean build environment, removing unnecessary files, and setting up the load path for the bundled gems. These changes help ensure that the Brakeman gem is packaged correctly and that the bundled package is free of unnecessary files and dependencies.

Overall, the changes in this pull request appear to be focused on improving the packaging and distribution of the Brakeman gem, which is an important aspect of maintaining the security and reliability of the tool.

Files Changed:

  1. brakeman.gemspec: The changes in this file exclude certain directories and files from the gem package, and explicitly add the racc gem as a dependency. These changes help reduce the size of the gem package and maintain the reliability of the Brakeman gem.

  2. build.rb: The changes in this file prepare a clean build environment, remove unnecessary files, and set up the load path for the bundled gems. These changes help ensure that the Brakeman gem is packaged correctly and that the bundled package is free of unnecessary files and dependencies.

Code Analysis

We ran 9 analyzers against 2 files and 0 analyzers had findings. 9 analyzers had no findings.

Riskiness

🟢 Risk threshold not exceeded.

View PR in the DryRun Dashboard.

@presidentbeef presidentbeef merged commit 43612a6 into main Oct 17, 2024
18 checks passed
@presidentbeef presidentbeef deleted the more_native_gems_to_ignore branch October 17, 2024 23:00
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant