Document area data #392
Open
Document area data #392
+1,086
−1,107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This documents the `ov5_021EF75C.c` file, which is in charge of loading various "area data" NARCs that, in the end, contain the textures of maps, the textures and models of map props, and lighting information. Also, renamed `MapProp.id` to `MapProp.modelID` for more clarity (especially when interacting with the new area data functions). Signed-off-by: Kuruyia <github@kuruyia.net>
Kuruyia
force-pushed
the
feat/document-area-data
branch
from
ba186c5 to
ba186eb
Compare
lhearachel
reviewed
Feb 22, 2025
Comment on lines
+36
to
+37
| // Note: the first element is the size of this array | ||
| u16 *mapPropModelIDs; |
There was a problem hiding this comment.
polish: I personally don't think that this comment is necessary, but am totally fine to keep it.
| #include "heap.h" | ||
| #include "narc.h" | ||
|
|
||
| #define MAP_PROP_MATERIAL_SHAPE_FILE_PATH "fielddata/build_model/build_model_matshp.dat" |
There was a problem hiding this comment.
thought: I personally don't see the value of this being a constant. We have some string-literals in the repository already.
| COLOR_DARK_GRAY | ||
| }; | ||
|
|
||
| static void AreaData_StripTextureData(void *ressourceFile, NNSG3dResTex *texture) |
There was a problem hiding this comment.
polish:
Suggested change
| static void AreaData_StripTextureData(void *ressourceFile, NNSG3dResTex *texture) | |
| static void AreaData_StripTextureData(void *resourceFile, NNSG3dResTex *texture) |
| return &(areaDataManager->mapPropModelFiles[0]); | ||
| } | ||
|
|
||
| return &(areaDataManager->mapPropModelFiles[mapPropModelID]); |
There was a problem hiding this comment.
polish: Unnecessary parens; &areaDataManager->mapPropModelFiles[mapPropModelID] should be totally valid.
Comment on lines
+215
to
+219
| if ((areaDataManager->areaData.areaLightArchiveID == 0) || (areaDataManager->areaData.areaLightArchiveID == 3)) { | ||
| return TRUE; | ||
| } else { | ||
| return FALSE; | ||
| } |
There was a problem hiding this comment.
question: Does this match as:
Suggested change
| if ((areaDataManager->areaData.areaLightArchiveID == 0) || (areaDataManager->areaData.areaLightArchiveID == 3)) { | |
| return TRUE; | |
| } else { | |
| return FALSE; | |
| } | |
| return areaDataManager->areaData.areaLightArchiveID == 0 || areaDataManager->areaData.areaLightArchiveID == 3; |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This documents the
ov5_021EF75C.cfile, which is in charge of loading various "area data" NARCs that, in the end, contain the textures of maps, the textures and models of map props, and lighting information.Also, renamed
MapProp.idtoMapProp.modelIDfor more clarity (especially when interacting with the new area data functions).