New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[DEV-15524] Fix - Make sure FloatingSnippetInput is not re-rendering if not needed #577

Merged

kudlajz merged 1 commit into main from feature/dev-15524-story-editor-snippet-dropdown-scroll-resets

Jan 14, 2025

Contributor

kudlajz commented Jan 10, 2025

added useFunction to not create new function references on every render
memoized the FloatingSnippetInput component to not re-render if the props haven't changed


          Make function props stable and memoize the component

d3768d6

kudlajz requested review from e1himself and yuriyyakym

January 10, 2025 12:34

kudlajz self-assigned this

Base automatically changed from feature/dev-14744-explore-migrating-to-plate-editor to main

January 14, 2025 12:06

kudlajz merged commit 046755a into main

7 checks passed

kudlajz deleted the feature/dev-15524-story-editor-snippet-dropdown-scroll-resets branch

January 14, 2025 12:08

# for free to join this conversation on GitHub. Already have an account? # to comment

Labels

None yet