Fixed a few windows issues, make Monogame optional without requiring .csproj edits #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foxnne
commented
Sep 22, 2019
foxnne
commented
- Fixed Build and Run (Debug) and Build and Run (Release) vscode tasks for Windows
- Modified MonoGameContent.targets to check for monogame being installed before running buildcontent after the build target, hopefully makes monogame optional without requiring editing of the csproj file. Tested fine on Windows with and without MG.
- Removed exit from dotnet check in getFNA.ps1, shouldnt exit if you don't want t4 templates or have dotnet installed now, matching original getFNA.sh
- moved nez-logo-black.png to the Content/Textures folder and switched load method in DefaultScene.cs to look for it there
Still need to fix up a few lingering things. Need to figure out how the original sln file was functioning with Release configuration without having a Release config set up. Would also be nice to have some way to install and run the powershell script from code, so it would be as simple as creating the folder for the new project > right click > open with Code > (run command from pallette for new Nez project from template)
Hopefully this now works with both OSX and Windows... I tried to create platform specific properties everywhere I could. All Windows build tasks for VSCode seem to be working correctly now.
Accidentally left in a testing name...
I had only tested the other configuration on a single project and in practice saw that the current vscode terminal location would cause a fail if it was in use. Now the build task uses a reference location... Also fixed a few of the build tasks which seemed to work before, but werent calling anymore for some reason using the & modifier. Now thye seem to always work using the powershell command to open the ps1 files.
Hopefully now have all the camelCases covered...
|
It's been a while, when I started with this I had issues on windows with the shell scripts and added a few changes I thought fit in. But I think prime has already ironed out windows issues without this PR? Probably should just be closed. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.