Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Splitter/SplitterPanel: size not updated #5463

Closed
matansha opened this issue Mar 22, 2024 · 2 comments · Fixed by #6394
Closed

Splitter/SplitterPanel: size not updated #5463

matansha opened this issue Mar 22, 2024 · 2 comments · Fixed by #6394
Assignees
@tugcekucukoglu
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
4.1.0

Comments

@matansha
Copy link

Describe the bug

Hi,

When i try to update the :size it's doing nothing. how can i update the sizes of the SplitterPanel manually?

Thanks!

Reproducer

https://stackblitz.com/edit/primevue-create-vue-issue-template-ctkwps?file=src%2FApp.vue

PrimeVue version

3.50.0

Vue version

3.x

Language

TypeScript

Build / Runtime

Vite

Browser(s)

All

Steps to reproduce the behavior

press the button that change the size
update heightOfCodes doing nothing...

Expected behavior

No response
@matansha matansha added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Mar 22, 2024
@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Apr 1, 2024
@tugcekucukoglu tugcekucukoglu added this to the 3.51.0 milestone Apr 1, 2024
@tugcekucukoglu tugcekucukoglu self-assigned this Apr 1, 2024
tugcekucukoglu added a commit that referenced this issue Apr 1, 2024
@tugcekucukoglu
Revert "Fixed #5463 - Splitter/SplitterPanel: size not updated"
4e3ae01 
This reverts commit cd18096.
@tugcekucukoglu tugcekucukoglu reopened this Apr 1, 2024
@tugcekucukoglu tugcekucukoglu modified the milestones: 3.51.0, 3.53.0 Apr 4, 2024
@matansha
Copy link
Author

matansha commented Apr 4, 2024 •
edited
Loading

Hi @tugcekucukoglu,

Thanks for your try.
Maybe you just need to extract this part to new function and call it when update or watch the size prop:
Screenshot 2024-04-04 at 12 47 31

it's seems it didn't work's because the initialized if. can you check this please?

@tugcekucukoglu tugcekucukoglu removed this from the 3.53.0 milestone Jun 27, 2024
@matansha
Copy link
Author

matansha commented Jul 1, 2024

@tugcekucukoglu Do you have any time estimation when it going to be fixed?

mehdirande pushed a commit to mehdirande/primevue that referenced this issue Sep 12, 2024
Proposal primefaces#5463: Add a resetState method to splitter to manu…
404771e 
…ally reset state.
@mehdirande mehdirande mentioned this issue Sep 12, 2024
Merged
@tugcekucukoglu tugcekucukoglu added this to the 4.1.0 milestone Sep 24, 2024
tugcekucukoglu added a commit that referenced this issue Sep 24, 2024
@tugcekucukoglu
Merge pull request #6394 from mehdirande/fix-5463-reset-splitter-state
00d7470 
Proposal for #5463: Add a resetState method to splitter to manually reset state
This was referenced Nov 11, 2024
Open
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@tugcekucukoglu tugcekucukoglu

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
4.1.0
Development

Successfully merging a pull request may close this issue.

Proposal for #5463: Add a resetState method to splitter to manually reset state mehdirande/primevue
2 participants
@matansha @tugcekucukoglu