Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(Carousel): allow autoplay when value has valid count #6902

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

KumJungMin
Copy link
Contributor

@KumJungMin KumJungMin commented Dec 1, 2024

Defect Fixes


How To Resolve

Solution

In autoplay mode, when the count of value is less than or equal to this.d_numVisible, a bug causing white space to appear occurs.
To resolve this, I validate that the count of value is sufficient.

 hasValidItemCount() {
      return this.value && this.value.length > this.d_numVisible;
  },

Test

Before: White space appeared.

1.mov

After: Autoplay is disabled, and the item is displayed correctly.

스크린샷 2024-12-01 오후 1 52 44

Copy link

vercel bot commented Dec 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Updated (UTC)
primevue ⬜️ Ignored (Inspect) Visit Preview Dec 1, 2024 5:06am
primevue-v3 ⬜️ Ignored (Inspect) Visit Preview Dec 1, 2024 5:06am

@tugcekucukoglu tugcekucukoglu merged commit cd1e762 into primefaces:master Dec 2, 2024
4 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Carousel: Item disappear when there is only one item with autoplay and circular activated
2 participants