Skip to content

New rule: check the new color CSS vars have a fallback #122

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 14 commits into from
Nov 29, 2023

Conversation

lukasoppermann
Copy link
Contributor

@lukasoppermann lukasoppermann commented Nov 29, 2023

This rule flags usage of new css variables that have no fallback.

Todo

  • add all css variables to json
  • test against dotCom to see if we have a lot of false positives

Copy link

changeset-bot bot commented Nov 29, 2023

🦋 Changeset detected

Latest commit: 660b680

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-primer-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@langermank langermank changed the title testing new rule to flag new css without fallback New rule: check the new color CSS vars have a fallback Nov 29, 2023
@langermank langermank marked this pull request as ready for review November 29, 2023 17:04
@langermank langermank requested review from a team and broccolinisoup November 29, 2023 17:04
Copy link
Contributor

@langermank langermank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in dotcom, works great!

@langermank langermank merged commit 3bc226a into main Nov 29, 2023
@langermank langermank deleted the new-css-vars-have-fallback branch November 29, 2023 21:11
@primer-css primer-css mentioned this pull request Nov 29, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants