fix(octicons_react): remove role if aria-hidden #1007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e98add7 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
broccolinisoup
approved these changes
Mar 5, 2024
| @@ -49,5 +49,6 @@ | |||
| "github/no-then": 0, | |||
| "eslint-comments/no-use": 0 | |||
| } | |||
| } | |||
| }, | |||
| "packageManager": "yarn@1.22.1" | |||
keithamus
approved these changes
Mar 13, 2024
Merged
4 tasks
This was referenced Sep 13, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small changes that makes
roleconditional on ifaria-labeloraria-labelledbyis present. This is to avoid having botharia-hiddenandroleon the element at the same time.This also updates the root
package.jsonfile so that contributors with yarn >2 don't mess with the lockfile locally