Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Migrate SubNav component to TSX #1038

Merged
merged 8 commits into from
Feb 11, 2021
Merged

Migrate SubNav component to TSX #1038

merged 8 commits into from
Feb 11, 2021

Conversation

VanAnderson
Copy link
Contributor

@VanAnderson VanAnderson commented Feb 9, 2021 •
edited
Loading

This PR migrates the SubNav component to TypeScript as part of the TypeScript refactor.

WIP, working through a couple issues

@changeset-bot
Copy link

changeset-bot bot commented Feb 9, 2021 •
edited
Loading

🦋 Changeset detected

Latest commit: 397d978

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Feb 9, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primer-components/apeyetx1b
✅ Preview: https://primer-components-git-vananderson-subnav-tsx-migration.primer.now.sh

@vercel vercel bot temporarily deployed to Preview February 9, 2021 18:17 Inactive
VanAnderson
VanAnderson commented Feb 9, 2021
View reviewed changes
src/SubNav.tsx Outdated
)
}

const SubNavLinks = (props: SystemFlexProps & SystemCommonProps & SxProp) => <Flex {...props} />
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@colebemis I'm having a bit of difficulty finding the correct type for this that won't generate a type error - any thoughts?

image

@VanAnderson VanAnderson mentioned this pull request Feb 9, 2021
Closed
53 tasks
@vercel vercel bot temporarily deployed to Preview February 10, 2021 21:45 Inactive
@VanAnderson
Copy link
Contributor Author

Ahh, few more things to clean up in the tests.... 👀

colebemis
colebemis reviewed Feb 10, 2021
View reviewed changes
@vercel vercel bot temporarily deployed to Preview February 10, 2021 22:21 Inactive
@vercel vercel bot temporarily deployed to Preview February 11, 2021 14:29 Inactive
@VanAnderson @colebemis
Revisions to SubNav TS migration
6b69a1c 
Co-authored-by: Cole Bemis <colebemis@github.com>
@VanAnderson VanAnderson force-pushed the VanAnderson/SubNav-TSX-migration branch from b9d81ff to 6b69a1c Compare February 11, 2021 14:49
@vercel vercel bot temporarily deployed to Preview February 11, 2021 14:49 Inactive
@VanAnderson VanAnderson marked this pull request as ready for review February 11, 2021 14:49
@vercel vercel bot temporarily deployed to Preview February 11, 2021 17:30 Inactive
@vercel vercel bot temporarily deployed to Preview February 11, 2021 17:43 Inactive
@colebemis colebemis merged commit 97da1af into main Feb 11, 2021
@colebemis colebemis deleted the VanAnderson/SubNav-TSX-migration branch February 11, 2021 17:53
@github-actions github-actions bot mentioned this pull request Feb 11, 2021
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@colebemis colebemis colebemis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VanAnderson @colebemis