Migrate Pagination to TypeScript #1047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a5389b8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/primer/primer-components/6s0z7dkb3 |
VanAnderson
changed the title
53 tasks
|
forgot to export PaginationProps! done in 43c79d6 |
|
8fb049d should fix the last failing TS error 🤞 |
colebemis
approved these changes
Feb 12, 2021
VanAnderson
force-pushed
the
VanAnderson/Pagination-tsx-migration
branch
from
21af95e to
53edf5e
Compare
Co-authored-by: Cole Bemis <colebemis@github.com>
VanAnderson
force-pushed
the
VanAnderson/Pagination-tsx-migration
branch
from
53edf5e to
cf6bb0b
Compare
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the
Paginationcomponent to TypeScript as part of the TypeScript refactor.