Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Prevents inactive indicator icon/tooltip from appearing in ActionMenu items #4770

Merged
merged 3 commits into from
Jul 24, 2024

Conversation

mperrotti
Copy link
Contributor

No issue exists for this bug. I think the bug was introduced as the result of a bad merge.

Screenshots

Before:

Kapture.2024-07-23.at.13.51.25.mp4

After:

Kapture.2024-07-23.at.13.53.27.mp4

Changelog

New

Changed

  • Inactive ActionMenu items no longer render a ⚠️ icon w/ the inactive warning message. The warning message is only rendered at the bottom of the ActionMenu item

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

  • For ActionList items: Ensure that the ⚠️ icon still appears and shows a tooltip on hover
  • For ActionMenu and NavList items: Ensure that no ⚠️ icon appears - only warning text at the bottom of the item

Merge checklist

  • [n/a] Added/updated tests
    • This will be caught by visual regression tests
  • [n/a] Added/updated documentation
  • [n/a] Added/updated previews (Storybook)
  • Changes are SSR compatible
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge
  • (GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)

@mperrotti mperrotti requested a review from a team as a code owner July 23, 2024 17:59
@mperrotti mperrotti requested a review from broccolinisoup July 23, 2024 17:59
Copy link

changeset-bot bot commented Jul 23, 2024

🦋 Changeset detected

Latest commit: 8c4fedf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jul 23, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 92.48 KB (+0.13% 🔺)
packages/react/dist/browser.umd.js 92.68 KB (-0.01% 🔽)

@github-actions github-actions bot temporarily deployed to storybook-preview-4770 July 23, 2024 18:03 Inactive
Copy link
Member

@broccolinisoup broccolinisoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful! Thanks for fixing this 🙌🏻

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants