fix(DOS): cross pool dos vector removed by refunding eth only if weth… #122
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… token
Discussion: #89 (comment)
For pools with
WETH
, the_transferFrom
will try to use the native ether for the payment ifmsg.value
is >= the amount required.If
msg.value
is not zero, but also not enough to make the payment, theelse
branch will be entered which will pull the full amount of WETH tokens from the sender.If
msg.value
is greater than the amount (leaving excess), or theelse
branch was entered, the remaining ether balance of the contract is sent to the sender. Note this is only if the token isWETH
,