Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat: Change types from ethers types to alloy types in cheatcodes #725

Merged
merged 5 commits into from
Dec 1, 2023
Merged

feat: Change types from ethers types to alloy types in cheatcodes #725

merged 5 commits into from
Dec 1, 2023

Conversation

quidproquoo
Copy link
Contributor

This is a draft PR for the issue #606

It seems like BlockId enum is no longer supported in alloy types. https://github.com/primitivefinance/arbiter/blob/c6ea6ab526afc1d9e349a501d2213d2b2d34115f/arbiter-core/src/environment/cheatcodes.rs#L28C9-L28C9

So what should be the approach here? Should I create a enum that wrappes both BlockHash and BlockNumber or do something else for that?

@Autoparallel
Copy link
Collaborator

I think using just BlockNumber is fine for now. We hadn't ever really used BlockHash before. We can always add it in later if need be!

@quidproquoo quidproquoo marked this pull request as ready for review November 29, 2023 10:08
@0xJepsen 0xJepsen linked an issue Nov 29, 2023 that may be closed by this pull request
Feat: Change cheat-code types from ethers types to alloy types #606
Closed
0xJepsen
0xJepsen approved these changes Nov 29, 2023
View reviewed changes
Copy link
Collaborator

@0xJepsen 0xJepsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@0xJepsen 0xJepsen enabled auto-merge November 30, 2023 22:19
@Autoparallel
Copy link
Collaborator

lgtm too.

Tests failing is not your problem. That's ours. I'll merge this now.

Good work @quidproquoo

@Autoparallel Autoparallel disabled auto-merge December 1, 2023 14:59
@Autoparallel Autoparallel merged commit aaba00a into anthias-labs:main Dec 1, 2023
@quidproquoo quidproquoo deleted the migrate-alloy branch December 1, 2023 18:38
Autoparallel added a commit that referenced this pull request Dec 5, 2023
@Autoparallel
Revert "Merge pull request #725 from quidproquoo/migrate-alloy"
b974100 
This reverts commit aaba00a, reversing
changes made to ed9f020.
@github-actions github-actions bot mentioned this pull request Dec 21, 2023
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@0xJepsen 0xJepsen 0xJepsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat: Change cheat-code types from ethers types to alloy types
3 participants
@quidproquoo @Autoparallel @0xJepsen