Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Generated files have an execution permissions on Linux #72

Merged
merged 2 commits into from
Jul 7, 2022

Conversation

dmvolod
Copy link
Contributor

@dmvolod dmvolod commented Jul 4, 2022

This fix set default permissions for the any documentation files as rw-rw-r or 0664
fixes #71

Copy link
Owner

@princjef princjef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks for the fix

@codecov-commenter
Copy link

Codecov Report

Merging #72 (63d9235) into master (80124ce) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master      #72   +/-   ##
=======================================
  Coverage   67.82%   67.82%           
=======================================
  Files          17       17           
  Lines        1557     1557           
=======================================
  Hits         1056     1056           
  Misses        415      415           
  Partials       86       86           
Impacted Files Coverage Δ
cmd/gomarkdoc/output.go 50.49% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80124ce...63d9235. Read the comment docs.

@luisdavim
Copy link

Folders need to be executable...

@dmvolod
Copy link
Contributor Author

dmvolod commented Jul 15, 2022

@luisdavim you are totally right, I changed incorrect permission here and fixed them in the #76

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generated files have an execution permissions on Linux
4 participants