Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: compute source map relative paths according to srcDir #8

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

lihbr
Copy link
Member

@lihbr lihbr commented Apr 12, 2023

Types of changes

  • Chore (a non-breaking change which is related to package maintenance)
  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Without this change, a source map for a file available under dist/index.js would indicate the source file to be relatively available at ../../src/index.ts where it is actually relatively available at ../src/index.ts

This change comes with the side-effect of enforcing type exports to be declared as such (export type {} from "") because they are not checked.

Unrelated: maintained dependencies & update license

Checklist:

  • My change requires an update to the official documentation.
  • All TSDoc comments are up-to-date and new ones have been added where necessary.
  • All new and existing tests are passing.

🦃

lihbr added 3 commits April 12, 2023 13:00
Without this change, a source map for a file available under `dist/index.js`
would indicate the source file to be relatively available at
`../../src/index.ts` where it is actually relatively available at
`../src/index.ts`

This change comes with the side-effect of enforcing type exports to be
declared as such (`export type {} from ""`) because they are not checked
@lihbr lihbr requested a review from angeloashmore April 12, 2023 11:24
@lihbr lihbr changed the title docs: update license fix: compute source map relative paths according to srcDir Apr 12, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant