-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: add fallback
option to avoid meaningless result.
#66
base: master
Are you sure you want to change the base?
feat: add fallback
option to avoid meaningless result.
#66
Conversation
3e42d9d
to
be179ac
Compare
Why would we need to accept a fallback if TypeScript doesn't accept a fallback? |
I was not sure if this is an intending behavior so I made it a feature not a bug fix. we can return an empty array when matched value is null on condition that you're sure the behavior to join baseUrl and a mismatched alias is really meaningless.🤔 |
how do you think about it ?🌚 |
I haven't had time to take a look yet, but very high chance I won't be accepting any options TypeScript doesn't accept. The point of this project is feature parity so it should do exactly what TypeScript does. |
emmm does it mean ts will join baseUrl and alias directly even if the path is meaningless ?Sorry I don't aware of this at that moment,if it is, just keep it as it was. |
Again, I haven't looked into this at all — haven't even understood what problem it's addressing. But for the tests, it runs TypeScript to get it's correct behavior via |
#65