Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: Remove cv reporter #1265

Merged
merged 7 commits into from
Jan 31, 2025
Merged

chore: Remove cv reporter #1265

merged 7 commits into from
Jan 31, 2025

Conversation

MarieSacksick
Copy link
Contributor

Now that we have the CV Report, and that the CV Reporter has been announced as deprecated in the previous version, we can drop the CV Reporter.

@MarieSacksick MarieSacksick marked this pull request as draft January 30, 2025 13:44
Copy link
Contributor

github-actions bot commented Jan 30, 2025

Coverage

Coverage Report for backend
FileStmtsMissCoverMissing
venv/lib/python3.12/site-packages/skore
   __init__.py140100% 
   __main__.py880%3–19
   exceptions.py440%4–23
venv/lib/python3.12/site-packages/skore/cli
   __init__.py550%3–8
   cli.py22220%3–70
   color_format.py49490%3–116
venv/lib/python3.12/site-packages/skore/persistence
   __init__.py00100% 
venv/lib/python3.12/site-packages/skore/persistence/item
   __init__.py56393%96–99
   altair_chart_item.py24193%15
   item.py24196%86
   matplotlib_figure_item.py42196%19
   media_item.py240100% 
   numpy_array_item.py29194%16
   pandas_dataframe_item.py31194%14
   pandas_series_item.py31194%14
   pickle_item.py330100% 
   pillow_image_item.py32194%16
   plotly_figure_item.py25193%15
   polars_dataframe_item.py29194%14
   polars_series_item.py24193%14
   primitive_item.py25291%13–15
   sklearn_base_estimator_item.py31194%15
   skrub_table_report_item.py10186%11
venv/lib/python3.12/site-packages/skore/persistence/repository
   __init__.py30100% 
   item_repository.py59591%15–16, 202–203, 226
   view_repository.py19286%9–10
venv/lib/python3.12/site-packages/skore/persistence/storage
   __init__.py40100% 
   abstract_storage.py220100% 
   disk_cache_storage.py33195%44
   in_memory_storage.py200100% 
venv/lib/python3.12/site-packages/skore/persistence/view
   __init__.py20100% 
   view.py50100% 
venv/lib/python3.12/site-packages/skore/project
   __init__.py30100% 
   _launch.py150199%278
   _open.py90100% 
   project.py71199%250
venv/lib/python3.12/site-packages/skore/sklearn
   __init__.py40100% 
   _base.py140497%91, 94, 168–>173, 183–184
   find_ml_task.py45487%71–>87, 80–86
   types.py20100% 
venv/lib/python3.12/site-packages/skore/sklearn/_cross_validation
   __init__.py60100% 
   metrics_accessor.py1630100% 
   report.py870100% 
venv/lib/python3.12/site-packages/skore/sklearn/_estimator
   __init__.py60100% 
   metrics_accessor.py265497%149–158, 183–>236, 191, 434–>437, 783–>786
   report.py120099%213–>219, 221–>223
   utils.py11110%1–19
venv/lib/python3.12/site-packages/skore/sklearn/_plot
   __init__.py40100% 
   precision_recall_curve.py121198%229–>246, 317
   prediction_error.py970100% 
   roc_curve.py1280100% 
   utils.py880100% 
venv/lib/python3.12/site-packages/skore/sklearn/train_test_split
   __init__.py00100% 
   train_test_split.py36294%16–17
venv/lib/python3.12/site-packages/skore/sklearn/train_test_split/warning
   __init__.py80100% 
   high_class_imbalance_too_few_examples_warning.py17378%16–18, 80
   high_class_imbalance_warning.py18288%16–18
   random_state_unset_warning.py11187%15
   shuffle_true_warning.py9091%44–>exit
   stratify_is_set_warning.py11187%15
   time_based_column_warning.py22189%17, 69–>exit
   train_test_split_warning.py5180%21
venv/lib/python3.12/site-packages/skore/ui
   __init__.py00100% 
   app.py32320%3–83
   dependencies.py440%3–10
   project_routes.py62620%3–145
   server.py17170%3–40
venv/lib/python3.12/site-packages/skore/utils
   __init__.py60100% 
   _accessor.py70100% 
   _environment.py26097%29–>34
   _logger.py21484%14–18
   _patch.py11546%19–35
   _progress_bar.py300100% 
   _show_versions.py310100% 
TOTAL264327489% 

Tests Skipped Failures Errors Time
547 3 💤 0 ❌ 0 🔥 2m 44s ⏱️

Copy link
Contributor

github-actions bot commented Jan 30, 2025

Documentation preview @ 512d636

@MarieSacksick MarieSacksick marked this pull request as ready for review January 30, 2025 15:04
@thomass-dev
Copy link
Collaborator

@MarieS-WiMLDS what about the corresponding part in skore-ui?

@MarieSacksick
Copy link
Contributor Author

what about the corresponding part in skore-ui?

I've been looking for it, but nothing appear when using words such as reporter or CrossValidationReporter in the search bar, therefore I assumed I had removed it.

Is it actually these?
image

@rouk1
Copy link
Contributor

rouk1 commented Jan 31, 2025

what about the corresponding part in skore-ui?

I've been looking for it, but nothing appear when using words such as reporter or CrossValidationReporter in the search bar, therefore I assumed I had removed it.

The files:

  • skore-ui/src/components/CrossValidationReport.vue
  • skore-ui/src/components/CrossValidationReportDetails.vue
  • skore-ui/src/components/CrossValidationReportPlots.vue
  • skore-ui/src/components/CrossValidationReportResults.vue

Can be removed, also they are imported in

  • skore-ui/src/views/ComponentsView.vue
  • skore-ui/src/components/MediaWidgetSelector.vue

Note that they might be re-added soon as I plan to reuse the design for the new reports.

@thomass-dev
Copy link
Collaborator

@rouk1 do you think it's better to only remove the skore part for now?

@rouk1
Copy link
Contributor

rouk1 commented Jan 31, 2025

You can remove it, it may be quite different in the future.

@thomass-dev
Copy link
Collaborator

@MarieS-WiMLDS i can merge in state, or i can wait you to remove the skore-ui part. You decide!

Copy link
Contributor

Coverage Report for frontend

Status Category Percentage Covered / Total
🔵 Lines 83.3% 3334 / 4002
🔵 Statements 83.3% 3334 / 4002
🔵 Functions 44.2% 61 / 138
🔵 Branches 82.87% 271 / 327
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
skore-ui/src/components/MediaWidgetSelector.vue 100% 100% 100% 100%
skore-ui/src/views/ComponentsView.vue 92.73% 100% 0% 92.73% 45-55, 61-86, 173-202, 206-215, 228-232, 236-242, 1383-1388, 1392-1399
Generated in workflow #184 for commit 512d636 by the Vitest Coverage Report Action

@thomass-dev thomass-dev merged commit 066e14b into main Jan 31, 2025
21 checks passed
@thomass-dev thomass-dev deleted the drop_old branch January 31, 2025 09:28
thomass-dev pushed a commit that referenced this pull request Jan 31, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants