Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Defer type-checking from object_to_item to Item classes #355

Merged

Conversation

thomass-dev
Copy link
Collaborator

No description provided.

@thomass-dev thomass-dev linked an issue Sep 18, 2024 that may be closed by this pull request
@thomass-dev thomass-dev force-pushed the 352-defer-type-checking-from-object_to_item-to-item-classes branch from c40188d to 63dd31e Compare September 18, 2024 16:06
Copy link
Contributor

github-actions bot commented Sep 18, 2024

Coverage Report for ./frontend

Status Category Percentage Covered / Total
🔵 Lines 86.78% 972 / 1120
🔵 Statements 86.78% 972 / 1120
🔵 Functions 58.33% 28 / 48
🔵 Branches 82.56% 90 / 109
File CoverageNo changed files found.
Generated in workflow #858

@thomass-dev thomass-dev force-pushed the 352-defer-type-checking-from-object_to_item-to-item-classes branch 3 times, most recently from 43c7185 to 4c10e2b Compare September 19, 2024 07:34
@thomass-dev thomass-dev force-pushed the 352-defer-type-checking-from-object_to_item-to-item-classes branch from 4c10e2b to 203abac Compare September 19, 2024 07:37
@thomass-dev thomass-dev marked this pull request as ready for review September 19, 2024 07:39
@thomass-dev thomass-dev self-assigned this Sep 19, 2024
Copy link
Contributor

@augustebaum augustebaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@thomass-dev thomass-dev force-pushed the 352-defer-type-checking-from-object_to_item-to-item-classes branch from cbab051 to bfa71c7 Compare September 19, 2024 14:36
@augustebaum augustebaum merged commit 99a931f into main Sep 19, 2024
1 check passed
@augustebaum augustebaum deleted the 352-defer-type-checking-from-object_to_item-to-item-classes branch September 19, 2024 14:42
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Defer type-checking from object_to_item to Item classes
4 participants