Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat(cli): Improve colors in CLI #960

Merged
merged 4 commits into from
Jan 8, 2025
Merged

feat(cli): Improve colors in CLI #960

merged 4 commits into from
Jan 8, 2025

Conversation

glemaitre
Copy link
Member

@glemaitre glemaitre commented Dec 15, 2024 •
edited
Loading

Improve the coloring to have a nicer CLI interaction.
I was just playing around. This PR is not ready for review.

But right now, it will look at something like that:

image

@glemaitre glemaitre marked this pull request as draft December 15, 2024 20:36
@glemaitre
Copy link
Member Author

glemaitre commented Dec 15, 2024 •
edited
Loading

After playing with rich in #962, I think that we should start adding some coloring based on the skore color (cyan/orange) to show the info.

@thomass-dev thomass-dev force-pushed the main branch 7 times, most recently from ad7922d to 469d1e5 Compare December 31, 2024 14:42
@glemaitre
Copy link
Member Author

glemaitre commented Jan 7, 2025 •
edited
Loading

This is the current coloring in line with the other CLI:

image

@glemaitre glemaitre marked this pull request as ready for review January 7, 2025 22:23
@thomass-dev thomass-dev merged commit 73f6d91 into probabl-ai:main Jan 8, 2025
19 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@thomass-dev thomass-dev thomass-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glemaitre @thomass-dev