Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(UI): Theme toggle #988

Merged
merged 26 commits into from
Dec 20, 2024
Merged

feat(UI): Theme toggle #988

merged 26 commits into from
Dec 20, 2024

Conversation

rouk1
Copy link
Contributor

@rouk1 rouk1 commented Dec 19, 2024

This PR introduces a theme toggle that overwrites user preferences.
Depends on #926 that introduces class based theme management.

UI preview

theme-switch.mp4

Copy link
Contributor

github-actions bot commented Dec 19, 2024

Coverage Report for ./skore-ui

Status Category Percentage Covered / Total
🔵 Lines 85.06% 3361 / 3951
🔵 Statements 85.06% 3361 / 3951
🔵 Functions 44.77% 60 / 134
🔵 Branches 82.09% 243 / 296
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
skore-ui/src/SkoreUi.vue 0% 0% 0% 0% 1-47
skore-ui/src/StandaloneWidget.vue 0% 0% 0% 0% 1-21
skore-ui/src/components/MarkdownWidget.vue 92.3% 75% 100% 92.3% 38-40
skore-ui/src/components/MediaWidgetSelector.vue 100% 100% 100% 100%
skore-ui/src/components/SlideToggle.vue 100% 100% 100% 100%
skore-ui/src/components/VegaWidget.vue 100% 100% 100% 100%
skore-ui/src/components/icons/SkoreLogo.vue 100% 100% 100% 100%
skore-ui/src/stores/modals.ts 100% 93.75% 84.61% 100%
skore-ui/src/stores/project.ts 73.15% 90% 61.9% 73.15% 34-37, 47-65, 73-80, 137-138, 246-252, 259-264, 271-276, 282-285, 298, 317-326, 361-362
skore-ui/src/stores/themes.ts 73.07% 50% 0% 73.07% 21-23, 27-28, 33-34
skore-ui/src/stores/toasts.ts 100% 88.88% 100% 100%
skore-ui/src/views/AppToolbar.vue 0% 0% 0% 0% 1-37
skore-ui/src/views/ComponentsView.vue 93.18% 100% 0% 93.18% 45-55, 61-86, 173-202, 206-215, 228-232, 236-242, 1361-1366
Generated in workflow #1683 for commit db5b6d9 by the Vitest Coverage Report Action

@thomass-dev thomass-dev changed the title Theme toggle feat(UI): Theme toggle Dec 19, 2024
Base automatically changed from notebook-widgets to main December 20, 2024 09:08
@rouk1 rouk1 marked this pull request as ready for review December 20, 2024 09:45
@thomass-dev thomass-dev merged commit d96e41d into main Dec 20, 2024
8 checks passed
@thomass-dev thomass-dev deleted the theme-toggle branch December 20, 2024 10:52
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants