Skip to content

Point cargo-project at a fixed version #73

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 1 commit into from
Closed

Point cargo-project at a fixed version #73

wants to merge 1 commit into from

Conversation

jonas-schievink
Copy link
Contributor

@jonas-schievink jonas-schievink commented Nov 12, 2019

Points the dependency at the git branch containing japaric/cargo-project#7. This makes cargo-flash usable for the Rubble demo. Unfortunately that still doesn't work (and is very slow), but this is good progress.

Closes https://github.com/probe-rs/probe-rs/issues/42

@therealprof
Copy link
Contributor

Do we really want to go down that rabbit hole of pinning git repositories?

Also doesn't this require the most recent version of cargo to actually work?

@jonas-schievink
Copy link
Contributor Author

Do we really want to go down that rabbit hole of pinning git repositories?

I would prefer not to, but I am not sure if cargo-project is currently maintained. If a new version of it is published, we can (and should) always switch to that.

Also doesn't this require the most recent version of cargo to actually work?

Which part? Member globs have been working for a while now. (probe-rs requires Rust 1.38 anyways, and that version works fine even with this)

@therealprof
Copy link
Contributor

Which part? Member globs have been working for a while now. (probe-rs requires Rust 1.38 anyways, and that version works fine even with this)

I thought the permission to depend on git repositories (if the version is pinned to a commit) in published crates was only recently added? If that works with Rust 1.38 then it should be fine.

@jonas-schievink
Copy link
Contributor Author

Ah, that's true, it means we can only publish from 1.39.0. 1.38.0 should be able to install that though. And if it can't, we can always publish a temporary crate.

@jonas-schievink
Copy link
Contributor Author

Actually that's not true, the dependency still needs to be published on crates.io. git-only dependencies do not work.

@therealprof
Copy link
Contributor

I was thinking of rust-lang/cargo#7333

@jonas-schievink
Copy link
Contributor Author

That's only for dev-dependencies and will probably never be supported for normal dependencies. Everything on crates.io is supposed to build without depending on external sources.

@therealprof
Copy link
Contributor

@jonas-schievink Yes I am aware. Just saying that was what I was thinking of when figuring out whether your change might potentially be acceptable. ;) But in this case I'd say it is not.

@jonas-schievink
Copy link
Contributor Author

cargo-project 0.2.3 has been released

Tiwalun pushed a commit that referenced this pull request Jan 13, 2023
73: Revert stupid hardcoded format for channels and add config r=Yatekii a=Yatekii



Co-authored-by: Noah Hüsser <yatekii@yatekii.ch>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cargo flash does not work inside members of a workspace
2 participants