Pop error or exception to PDE #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaocegege
changed the title
|
Yes, redirecting to PDE is a good idea (no popup). Note that 3.3.4 currently has a regression bug with console output -- so test against 3.3.3 or wait for a fix: Update: The bug in 3.3.4 can be fixed by editing |
|
Thanks for the information! |
|
It is weird that renjin does't throw a exception when it should, for example, |
gaocegege
force-pushed
the
error/pop-to-pde
branch
from
c6eca43 to
bcf17f5
Compare
Signed-off-by: Ce Gao <ce.gao@outlook.com>
Signed-off-by: Ce Gao <ce.gao@outlook.com>
Signed-off-by: Ce Gao <ce.gao@outlook.com>
Signed-off-by: Ce Gao <ce.gao@outlook.com>
Signed-off-by: Ce Gao <ce.gao@outlook.com>
gaocegege
force-pushed
the
error/pop-to-pde
branch
from
bcf17f5 to
efee843
Compare
|
The logic is a little more complex since there are some new errors, sucd as package download error |
Signed-off-by: Ce Gao <ce.gao@outlook.com>
|
Now the exceptions be will shown in the PDE, but it could not show the line and column. |
Signed-off-by: Ce Gao <ce.gao@outlook.com>
gaocegege
changed the title
|
The implementation imports a new bug: #143 The bug also exists in Python mode, I have filed a new issue about it. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #24
We should redirect the exception into PDE.
Signed-off-by: Ce Gao ce.gao@outlook.com