Skip to content

Problems with existing mobile components #2184

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
4 of 6 tasks
lindapaiste opened this issue Mar 26, 2023 · 5 comments
Closed
4 of 6 tasks

Problems with existing mobile components #2184

lindapaiste opened this issue Mar 26, 2023 · 5 comments

Comments

@lindapaiste
Copy link
Collaborator

lindapaiste commented Mar 26, 2023

I'm making this issue to document some of the problems with the existing MobileIDEView (and other mobile components) and keep track of them as I fix them. There are a lot of features that haven't been implemented, but I'm focusing more on bugs and mistakes.

Note that none of the mobile UI is available to end users at the moment due to the MOBILE_ENABLED flag, which is false in production.

image

  • 2. 404 Not Found error when accessing /preferences directly:
    These URLs need to be added to the server in addition to the client. Which is simple enough, but also annoying and feels fragile.

image

  • 3. App crashes when selecting Theme due to invalid value "Dark" instead of "dark".
    This gets saved to the user's preferences in the API and cannot be fixed by the user.
    Fixed by Fix problems in MobileIDEView (#2184) #2185

image

image
image

image

  • 6. Preview doesn't do anything, due to these postMessage errors:
    I have not figured out why this works on the desktop version but doesn't work here.
    image
@dewanshDT
Copy link
Collaborator

dewanshDT commented Mar 26, 2023

hey @lindapaiste I'm already working on these issues on this branch dewansh-mobile, but these issues are not well documented

@lindapaiste
Copy link
Collaborator Author

lindapaiste commented Mar 26, 2023

hey @lindapaiste I'm already working on these issues on this branch dewansh-mobile, but these issues are not well documented

ah cool. I see you found a use for the FloatingNav, which I deleted in my PR because it's not used anywhere. whoops.

I managed to fix most of the issues in my list but not all of them. I'm mostly trying to get it to a "clean slate" point where you and me and anyone else can work on finishing the mobile UI [redacted] from a better starting point.

@dewanshDT
Copy link
Collaborator

yeah, that would be great!

@raclim
Copy link
Collaborator

raclim commented Mar 26, 2023

@lindapaiste Thanks for your work on this so far!

We encourage contributions from all types of learners with varying backgrounds and levels of knowledge, so some of the code in this repository might not reflect as much technical experience as others. I feel that referring to someone else's prior work like that might be discouraging, and kindly suggest aiming towards language that's mindful of everyone's contribution journeys!

@lindapaiste
Copy link
Collaborator Author

Closing as stale since we are no longer using these particular components.

@lindapaiste lindapaiste closed this as not planned Won't fix, can't repro, duplicate, stale Oct 11, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

3 participants