-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Problems with existing mobile components #2184
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Comments
hey @lindapaiste I'm already working on these issues on this branch dewansh-mobile, but these issues are not well documented |
ah cool. I see you found a use for the I managed to fix most of the issues in my list but not all of them. I'm mostly trying to get it to a "clean slate" point where you and me and anyone else can work on finishing the mobile UI [redacted] from a better starting point. |
yeah, that would be great! |
@lindapaiste Thanks for your work on this so far! We encourage contributions from all types of learners with varying backgrounds and levels of knowledge, so some of the code in this repository might not reflect as much technical experience as others. I feel that referring to someone else's prior work like that might be discouraging, and kindly suggest aiming towards language that's mindful of everyone's contribution journeys! |
Closing as stale since we are no longer using these particular components. |
I'm making this issue to document some of the problems with the existing
MobileIDEView
(and other mobile components) and keep track of them as I fix them. There are a lot of features that haven't been implemented, but I'm focusing more on bugs and mistakes.Note that none of the mobile UI is available to end users at the moment due to the
MOBILE_ENABLED
flag, which isfalse
in production.Fixed by Fix problems in
MobileIDEView
(#2184) #2185/preferences
directly:These URLs need to be added to the
server
in addition to theclient
. Which is simple enough, but also annoying and feels fragile."Dark"
instead of"dark"
.This gets saved to the user's preferences in the API and cannot be fixed by the user.
Fixed by Fix problems in
MobileIDEView
(#2184) #2185Fixed by Fix problems in
MobileIDEView
(#2184) #2185PreviewFrame
which don't do anything, because that component only accepts one prop (fullView
):Fixed by Fix problems in
MobileIDEView
(#2184) #2185postMessage
errors:I have not figured out why this works on the desktop version but doesn't work here.
The text was updated successfully, but these errors were encountered: