-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Fix problems in MobileIDEView
(#2184)
#2185
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # client/modules/IDE/pages/IDEView.jsx
…factor/props-drilling # Conflicts: # client/modules/IDE/components/Editor.jsx # client/modules/IDE/components/Feedback.jsx
…rilling # Conflicts: # client/modules/IDE/components/Editor.jsx # client/modules/IDE/components/Feedback.jsx # client/modules/IDE/components/Preferences/index.jsx # client/modules/IDE/components/ShareModal.jsx # client/modules/IDE/pages/IDEView.jsx
6 tasks
4 tasks
Hey, I noticed you closed #2184, so I'm going to go ahead with closing this as well! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds upon PR #2054
Progress on issue #2184
Changes:
Preferences:
MobilePreferences
is now a wrapper around the mainPreferences
content instead of recreating it.className
prop onPreferences
so that it can be restyled withstyled-components
.Screen
be an extension of the desktopRootPage
, which applies global text colors based on the current theme. So now those text colors are applied to thePreferences
.PreferencePicker
which is no longer needed."MobilePreferences"
key from translations, since this data already exists in"Preferences"
.Navigation:
getNavOptions
into a componentNavMenu
because it's super weird to call hooks inside a plain function.NavMenu
items (logged out and logged in) rather than repeating the shared items twice.ActionStrip
.FloatingNav
which is not used.MobileIDEView:
react-redux
hooksuseSelector
anduseDispatch
instead ofconnect
.connect
props by connecting components deeper in the tree instead of props drilling.withChangeDot
in theMobileIDEView
and the original lines in theEditor
into a reusableUnsavedChangesIndicator
component so that it doesn't need to be repeated in both versions.IDEView
into a new componentAutosaveHandler
which can be used byMobileIDEView
. I'm considering this a temporary solution because I did not remove the code fromIDEView
so now we have it two places.Etc:
PreviewFrame
as they don't do anything.I have verified that this pull request:
npm run lint
)npm run test
)develop
branch.Fixes #123