Skip to content

refactor project reducers and actions using redux toolkit #3122

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

PiyushChandra17
Copy link
Contributor

Associated issue: #2042

Changes:

  • First things first removed all the associated constants
  • Used createSlice to rewrite the project reducer
  • Exported the automatically generated action creator functions from actions/project.js
  • Deleted the existing action creator function

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

state.isSaving = false;
},
resetProject(state) {
Object.assign(state, initialState);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't right because initialState is a function. It can be written as return initialState().

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants