Skip to content

Implement splineProperty #7471

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Implement splineProperty #7471

merged 1 commit into from
Jan 20, 2025

Conversation

davepagurek
Copy link
Contributor

Resolves #6766

Changes:

  • Replaces splineEnds(mode) with splineProperty('ends', mode)
  • Replaces curveTightness(t) with splineProperty('tightness', t)
  • Fixes a bug where curve tightness was not being correctly passed to shapes
  • Adjusts the shift threshold in visual tests: I had bumped it up before to be lenient enough for text rendering in different environments, but this was making tests pass for a curve tightness test when they shouldn't. I've updated it to be lower by default, and able to be updated per-suite, so text tests can be more lenient.

@davepagurek davepagurek marked this pull request as ready for review January 16, 2025 21:55
@davepagurek davepagurek merged commit fd39484 into dev-2.0 Jan 20, 2025
2 checks passed
@davepagurek davepagurek deleted the splineProperty branch January 20, 2025 00:07
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant