Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Run sync task in its own thread #1160

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

medihack
Copy link
Member

Closes #1124

Successful PR Checklist:

  • Tests
    • (not applicable?)
  • Documentation
    • (not applicable?)

PR label(s):

As discussed in #1156, this may not be a breaking change but rather a fix for an issue, because synchronous tasks in concurrency mode currently don't run in parallel but consecutively.

@medihack medihack requested a review from a team as a code owner August 15, 2024 12:28
@github-actions github-actions bot added the PR type: bugfix 🕵️ Contains bug fix label Aug 15, 2024
Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  procrastinate
  utils.py
Project Total  

This report was generated by python-coverage-comment-action

@ewjoachim
Copy link
Member

(you can change the base of a PR, you don't have to recreate one. Use the "Edit" button to the right of the title)
Screenshot 2024-08-15 at 17 06 20

Copy link
Member

@ewjoachim ewjoachim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

@ewjoachim ewjoachim merged commit 3629782 into procrastinate-org:main Aug 15, 2024
12 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
PR type: bugfix 🕵️ Contains bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating an asyncio loop in a sync task
2 participants