Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fill missing generic type parameters for JobContext.task #1218

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

fau-st
Copy link
Contributor

@fau-st fau-st commented Oct 8, 2024

Closes #1201

Successful PR Checklist:

  • Tests
    • (not applicable?)
  • Documentation
    • (not applicable?)

PR label(s):

Use Any for now but ideally JobContext should also be made generic.
@fau-st fau-st requested a review from a team as a code owner October 8, 2024 08:26
@github-actions github-actions bot added PR type: bugfix 🕵️ Contains bug fix PR type: miscellaneous 👾 Contains misc changes labels Oct 8, 2024
Copy link

github-actions bot commented Oct 8, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  procrastinate
  job_context.py
Project Total  

This report was generated by python-coverage-comment-action

Copy link
Member

@ewjoachim ewjoachim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks !

@ewjoachim ewjoachim merged commit 48b4ee9 into procrastinate-org:main Oct 8, 2024
13 checks passed
@fau-st fau-st deleted the patch-1 branch October 8, 2024 09:34
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
PR type: bugfix 🕵️ Contains bug fix PR type: miscellaneous 👾 Contains misc changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minor regression in types
2 participants