fix fetch job performance regression #1225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
PR type: bugfix 🕵️
Coverage report
Click to see where and how coverage changed
The report is truncated to 25 files out of 28. To see the full report, please visit the workflow summary page. This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
onlyann
force-pushed
the
fetch-jobs-indexes
branch
from
382665b to
c815369
Compare
ewjoachim
approved these changes
Oct 19, 2024
| @@ -0,0 +1,7 @@ | |||
| -- recreate procrastinate_jobs_id_lock_idx index by adding aborting status to the filter so that it can be used by the fetch job function | |||
| CREATE INDEX procrastinate_jobs_id_lock_idx_temp ON procrastinate_jobs (id, lock) WHERE status = ANY (ARRAY['todo'::procrastinate_job_status, 'doing'::procrastinate_job_status, 'aborting'::procrastinate_job_status]); | |||
There was a problem hiding this comment.
Note for self, don't forget to tell people in the release notes to create the index concurrently if applicable.
|
Released, and added some migration notes: |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies indexes to improve performance of the
fetch_jobfunction.Recently added features such as job priority and aborting jobs have introduced a performance regression.
It fixes that performance regression by updating an existing index and adding a new one so that the
fetch_jobfunction avoids sequential scans of the job table in both the outer and inner query.It also contains an additional timing tweak to an acceptance test to make it less flaky
Successful PR Checklist:
PR label(s):