Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Changes to the doc & django integration #960

Merged
merged 9 commits into from
Mar 6, 2024
Merged

Changes to the doc & django integration #960

merged 9 commits into from
Mar 6, 2024

Conversation

ewjoachim
Copy link
Member

Relates to #934

  • Remove the Django DB router. I'm not convinced it was a good idea, and it will complicate things.
  • ProcrastinatePeriodicDefer should be readonly
  • add PROCRASTINATE_READONLY_MODELS setting to ease testing
  • Break Django doc into multiple docs
  • Add a django test doc with unit & integration fixtures snippets (promoting InMemoryConnector)

Successful PR Checklist:

  • Tests
    • (not applicable?)
  • Documentation
    • (not applicable?)

PR label(s):

@github-actions github-actions bot added the PR type: documentation 📚 Contains documentation updates label Mar 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 3, 2024 •
edited
Loading

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  procrastinate/contrib/django
  __init__.py
  models.py
Project Total  

This report was generated by python-coverage-comment-action

@ewjoachim ewjoachim marked this pull request as ready for review March 4, 2024 00:03
@ewjoachim ewjoachim requested a review from a team as a code owner March 4, 2024 00:03
@ewjoachim ewjoachim force-pushed the django-tests-doc branch 3 times, most recently from dae5b62 to c5d04b5 Compare March 4, 2024 22:42
@ewjoachim ewjoachim force-pushed the django-tests-doc branch 2 times, most recently from e4fdc51 to 6136752 Compare March 4, 2024 23:01
@ewjoachim
Copy link
Member Author

the django reference doc is still failing

@ewjoachim ewjoachim enabled auto-merge March 6, 2024 21:18
@ewjoachim ewjoachim merged commit 22d10f6 into main Mar 6, 2024
10 checks passed
@ewjoachim ewjoachim deleted the django-tests-doc branch March 6, 2024 21:20
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR type: documentation 📚 Contains documentation updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ewjoachim