Skip to content

Update asciidoctor requirement from 1.5.6.2 to 2.0.10 #1454

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 2, 2020

Updates the requirements on asciidoctor to permit the latest version.

Release notes

Sourced from asciidoctor's releases.

v2.0.10

Summary

This is a minor bug fix release that patches two regression, one when using the header_footer option with Asciidoctor.convert_file and one when the icons attribute is set to image. It also addresses a minor issue in the default stylesheet with excerpt blocks and passes a consistent set of arguments to SyntaxHighlighter#docinfo. The Japanese version of the README has been brought up to date thanks to @soishino and @wotsushi.

Distributions

Asciidoctor is also packaged for Fedora, Debian, Ubuntu, Alpine Linux, OpenSUSE, and Homebrew. You can use the system's package manager to install the package named asciidoctor.

Release meta

Released on: 2019-05-31 Released by: @mojavelinux Release beer: Elevated IPA by La Cumbre

Logs: resolved issues | full diff | issues resolved in 2.0.x (cumulative)

Changelog

Bug Fixes

  • fix Asciidoctor.convert_file to honor header_footer: false option when writing to file (#3316)
  • fix placement of title on excerpt block (#3289)
  • always pass same options to SyntaxHighlighter#docinfo, regardless of value of location argument
  • fix signature of SyntaxHighlighter#docinfo method (#3300)
  • when icons is set to image, enable image icons, but don't use it as the value of the icontype attribute (#3308)
Changelog

Sourced from asciidoctor's changelog.

== 2.0.10 (2019-05-31) - @mojavelinux

Bug Fixes::

  • fix Asciidoctor.convert_file to honor header_footer: false option when writing to file (#3316)
  • fix placement of title on excerpt block (#3289)
  • always pass same options to SyntaxHighlighter#docinfo, regardless of value of location argument
  • fix signature of SyntaxHighlighter#docinfo method (#3300)
  • when icons is set to image, enable image icons, but don't use it as the value of the icontype attribute (#3308)

// end::compact[] == 2.0.9 (2019-04-30) - @mojavelinux

Bug Fixes::

  • process multiple single-item menu macros in same line (#3279)
  • register images in catalog correctly (#3283)
  • rename AbstractNode#options method to AbstractNode#enabled_options so it doesn't get shadowed by Document#options (#3282)
  • don't fail to convert document if alt attribute is not set on block or inline image (typically by an extension)
  • fix lineno of source location on blocks that follow a detached list continuation (#3281)
  • assume inline image type is "image" if not set (typically by an extension)

== 2.0.8 (2019-04-22) - @mojavelinux

Bug Fixes::

  • restore background color applied to literal blocks by default stylesheet (#3258)
  • use portability constants (CC_ALL, CC_ANY) in regular expressions defined in built-in converters (DocBook5 and ManPage)
  • use portability constant (CC_ANY) in regular expression for custom inline macros
  • use smarter margin collapsing for AsciiDoc table cell content; prevent passthrough content from being cut off (#3256)
  • don't limit footnote ref to ASCII charset; allow any word character in Unicode to be used (#3269)

Improvements::

  • register_for methods accept arguments as symbols (#3274)
  • use Concurrent::Map instead of Concurrent::Hash in template converter
  • use module_function keyword to define methods in Helpers
  • move regular expression definitions to separate source file (internal change)

== 2.0.7 (2019-04-13) - @mojavelinux

Bug Fixes::

  • fix crash when resolving ID from text and at least one candidate contains an unresolved xref (#3254)
  • fix compatibility with Rouge 2.0

Improvements::

  • improve documentation for the -a CLI option; explain that @ modifier can be placed at end of name as alternative to end of value
  • move source for main API entry points (load, load_file, convert, convert_file) to separate files (internal change)
Commits
  • 9302213 Release 2.0.10
  • eb685d9 add missing entry for #3110 to CHANGELOG [skip ci]
  • 8f83870 resolves #3316 fix Asciidoctor.convert_file to honor header_footer: false opt...
  • 66ae48d Synchronize Japanese README with English version (PR #3301)
  • e1beaa9 add missing entry to CHANGELOG for #3308 [skip ci]
  • c28ad27 refine emdash replacement
  • 2acdcec resolves #3308 honor image value for icons attribute
  • 1956a18 resolves #3300 fix signature of SyntaxHighlighter#docinfo method (PR #3303)
  • e272e40 always pass same options to SyntaxHighlighter#docinfo method
  • ae6440c add missing changelog entry for #3289 [skip ci]
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependabot label Jul 2, 2020
@dependabot dependabot bot requested a review from ben July 2, 2020 05:37
@HonkingGoose
Copy link
Contributor

Related discussions can be found here:
#1355
#1373

We should apply the Asciidoctor migration cheat sheet before upgrading to 2.0.10:
https://asciidoctor.org/docs/migration/#migration-cheatsheet

@HonkingGoose
Copy link
Contributor

@jnavila I think we should close this issue, so that nobody can get confused between our migration and the automated Dependabot one.

@jnavila jnavila closed this Oct 4, 2020
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 4, 2020

OK, I won't notify you again about this release, but will get in touch when a new version is available.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/bundler/asciidoctor-2.0.10 branch October 4, 2020 15:27
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants