Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added FAQs to JISC/TNA/PH CfP #2295

Merged
merged 2 commits into from
Sep 24, 2021
Merged

Added FAQs to JISC/TNA/PH CfP #2295

merged 2 commits into from
Sep 24, 2021

Conversation

tiagosousagarcia
Copy link
Contributor

@tiagosousagarcia tiagosousagarcia commented Sep 23, 2021

Closes #2294

Adding a FAQ list to the PH/JISC/TNA blogpost/CfP

Checklist

  • Assign yourself in the "Assignees" menu
  • Assign at least one individual or team to "Reviewers"
    • if the text needs to be translated, assign the relevant language team(s) as "Reviewers" and tag both the team as well as the managing edtor in your PR. Please follow the translation request guidelines when writing your PR description
  • Add the appropriate "Label"
  • Ensure the status checks pass
  • Check the live preview of your PR on Netlify
  • If this PR closes an open issue, add the phrase Closes #ISSUENUMBER to the description above

If you are having difficulty fixing build errors, first consult https://github.com/programminghistorian/jekyll/wiki/Making-Technical-Contributions carefully, especially "Common Build Errors". Then contact the technical team if you need further help.

Please check the wording of both Qs and As -- and in particular the answers to the questions around selection (criteria, panel) which I am a bit uncertain of. I've put the FAQs at the bottom of the post, let me know if top would be best (or anywhere else for that matter).

I've also added the links to the Portuguese archives @DanielAlvesLABDH suggested (edited their description slightly to fit with the existing links)

@tiagosousagarcia tiagosousagarcia added the 2021/22-JiscTNA matters relating to the Jisc & The National Archives partnership (2021-22) label Sep 23, 2021
@tiagosousagarcia tiagosousagarcia self-assigned this Sep 23, 2021
@tiagosousagarcia
Copy link
Contributor Author

tiagosousagarcia commented Sep 23, 2021

There's a link failing in the En lesson 'Working with batches of PDF files' -- I believe the contente of that link is now (somewhere) on this page (https://docs.microsoft.com/en-us/windows/wsl/wsl-config), but maybe someone from @programminghistorian/english-team could confirm it

@drjwbaker
Copy link
Member

There's a link failing in the En lesson 'Working with batches of PDF files' -- I believe the contente of that link is now (somewhere) on this page (https://docs.microsoft.com/en-us/windows/wsl/wsl-config), but maybe someone from @programminghistorian/english-team could confirm it

This is fixed in PR #2292 but we're waiting on translation there to pull. @anisa-hawes: I'm going to pull #2292 to fix the build issue, then we can open a seperate ticket for FR/PT translation of our charitable status.

@drjwbaker
Copy link
Member

I reckon these checks will pass now.

@tiagosousagarcia
Copy link
Contributor Author

I reckon these checks will pass now.

Thanks @drjwbaker -- just pulled the new changes into this branch, so should be good to go (once the checks finish)

@drjwbaker drjwbaker merged commit d865024 into programminghistorian:gh-pages Sep 24, 2021
@drjwbaker
Copy link
Member

Help @programminghistorian/technical-team - I merged this PR but I'm getting build fail emails https://github.com/programminghistorian/jekyll/actions/runs/1270207464

@tiagosousagarcia
Copy link
Contributor Author

Help @programminghistorian/technical-team - I merged this PR but I'm getting build fail emails https://github.com/programminghistorian/jekyll/actions/runs/1270207464

I think that build fail is from my forked repository (which, I think, fails because the PH domain name is already taken) -- not sure why these are appearing in the main repo though :s

@drjwbaker
Copy link
Member

Hmm. I've raised with the tech team on Slack (and invited you to the slack in case it is useful for you to be there, which is to say you don't have to join!)

@drjwbaker
Copy link
Member

The changes are at least showing on the site. Which is good!

@ZoeLeBlanc
Copy link
Member

Taking a look now! And feel free to chime in on Slack @tiagosousagarcia !! So just to clarify you were able to merge in @drjwbaker even though the build failed? Or rather the merge seemed to have worked even though the build failed?

@drjwbaker
Copy link
Member

@ZoeLeBlanc Checks passed, so I merged, then I got emails saying build had failed.

@tiagosousagarcia
Copy link
Contributor Author

Hmm. I've raised with the tech team on Slack (and invited you to the slack in case it is useful for you to be there, which is to say you don't have to join!)

Thanks! Could you invite me using the email I have here though? that's where all my slack action happens :)

@ZoeLeBlanc
Copy link
Member

Ya I think the issue is definitely the fork! It seems like this person had a similar issue here actions/toolkit#465. I'm not sure if forks get secret tokens yet or not 🤔

Is there a reason to do a fork of the repo @tiagosousagarcia ? Or could you just clone locally and make a normal branch? Happy to investigate this issue further but might need to pause for a bit because of a meeting soon

@tiagosousagarcia
Copy link
Contributor Author

Ya I think the issue is definitely the fork! It seems like this person had a similar issue here actions/toolkit#465. I'm not sure if forks get secret tokens yet or not 🤔

Is there a reason to do a fork of the repo @tiagosousagarcia ? Or could you just clone locally and make a normal branch? Happy to investigate this issue further but might need to pause for a bit because of a meeting soon

Not particularly, no -- other than for keeping any (potentially catastrophic) changes well and truly separate from the repo. I think I did it as a matter of course, but I don't have to do it

@drjwbaker
Copy link
Member

Thanks @ZoeLeBlanc. I guess my question is, can we leave this and just avoid forking in the future? Or do we need to roll-back this merge, then do it again without forking?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
2021/22-JiscTNA matters relating to the Jisc & The National Archives partnership (2021-22)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potential FAQs derived from PH/JISC/TNA author event
3 participants