Adds UPDATE to the RayCluster Mutating Webhook so apply can be used #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akram
changed the title
akram
force-pushed
the
add-update-to-raycluster-mutating-webhook
branch
from
c111e0a to
dc7021d
Compare
|
Just a note - it may be good to convert the PR to draft itself - that will avoid accidental merge. |
akram
changed the title
sutaakar
approved these changes
Dec 17, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sutaakar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 8ad4785
into
project-codeflare:main
8 checks passed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
What changes have been made
Adds UPDATE to the list of operations on which the
RayClusterMutating Webhookoperates on.This allows to
oc apply -foroc replaceto work and gives the ability to update existing runningrayclusterswithout deleting them.Verification steps
Redeploy the mutating webhook and create, update and delete rayclusters and re-create them.
Checks