Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: merging sbom docs is broken #68

Merged
merged 1 commit into from
May 9, 2024

Conversation

rchincha
Copy link
Contributor

What type of PR is this?

Which issue does this PR fix:

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rchincha rchincha force-pushed the missing2 branch 2 times, most recently from a31069c to 94a96f3 Compare May 7, 2024 18:09
@rchincha rchincha changed the title Missing2 fix: merging sbom docs is broken May 8, 2024
stacker frequently uses derived image builds and in turn relies on sbom
doc merges to be accurate.

Original code here only does a map merge which is incorrect.

Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>
@rchincha rchincha merged commit 4d685e0 into project-stacker:main May 9, 2024
8 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant