add no-sandbox flag #3863
Closed
add no-sandbox flag #3863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehsandeep
added
the
Status: In Progress
ehsandeep
added
the
Type: Maintenance
Mzack9999
approved these changes
Jul 3, 2023
There was a problem hiding this comment.
Implementation: lgtm
Note: this change will prevent nuclei from connecting to private ipv4/ipv6 ranges, making it unusable within VPC, CI/CD, and internal pipelines. I recommend evaluating carefully before proceeding (a possible solution could be to implement different level of sandboxing with still internal ranges enabled by default).
ehsandeep
added
Status: On Hold
ehsandeep
requested changes
Jul 7, 2023
There was a problem hiding this comment.
since sandbox component involves, disabling both can cause issues for default behavior, we can expose file and network options with separate CLI options to have better control and nonbreaking changes.
-lfa, -allow-local-file-access allows file (payload) access anywhere on the system
-lna, -restrict-local-network-access blocks connections to the local / private network
ehsandeep
added
Status: Revision Needed
|
Suppressed by #3927 |
ehsandeep
removed
the
Status: Revision Needed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The PR removes the sandbox flag and makes the sandbox mode default. In addition, it adds a no-sandbox flag to allow users to turn off the default sandbox mode if they choose to do so. Closes #3784.
Checklist