Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Starting again activity does does not use category of past activity #38

Closed
invidian opened this issue Feb 24, 2021 · 3 comments
Closed

Starting again activity does does not use category of past activity #38

invidian opened this issue Feb 24, 2021 · 3 comments
Assignees
@aquaherd

Comments

@invidian
Copy link
Contributor

It seems hitting green arrow on past activity does not copy over the category of previous activity to the new one.
@aquaherd aquaherd self-assigned this Feb 25, 2021
@aquaherd
Copy link
Member

I can reproduce - it is 'empty category'.
Same with if you have 'someproject@work' and 'someproject@homeoffice'.
Will fix this.

aquaherd added a commit that referenced this issue Mar 7, 2021
@aquaherd
#38: Starting again activity does does not use category of past activity
68da2e6 
This was possibly a problem with hamster legacy. In the gk+2 world,
starting a fact with an empty category via dbus would autmatically
append the most recent cateogory of the fact. Now with gtk+3,
an empty category is passed through verbatim.

Thankfully, filtering the GetActivities method from the entry text
returns the categories in recent order and we can pick the last used.
@aquaherd
Copy link
Member

aquaherd commented Mar 7, 2021

Hi @invidian could you please review if this works for you?

@invidian
Copy link
Contributor Author

invidian commented Mar 7, 2021

Works as expected, thanks for figuring it out!

@aquaherd aquaherd closed this as completed Mar 7, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@aquaherd aquaherd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aquaherd @invidian