Skip to content

Preserve removals before inserts #462

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
Apr 15, 2025
Merged

Preserve removals before inserts #462

merged 3 commits into from
Apr 15, 2025

Conversation

Shatur
Copy link
Contributor

@Shatur Shatur commented Apr 15, 2025

To avoid inconsistent triggers behavior between the server and client. Fixes #458.

First two commits just adjust related variable names. The actual fix in the third one.

@Shatur Shatur enabled auto-merge (squash) April 15, 2025 15:19
@Shatur Shatur requested a review from UkoeHB April 15, 2025 15:20
@Shatur Shatur linked an issue Apr 15, 2025 that may be closed by this pull request
Copy link

codecov bot commented Apr 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.30%. Comparing base (1e42c4f) to head (5243ae9).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #462      +/-   ##
==========================================
- Coverage   80.33%   80.30%   -0.04%     
==========================================
  Files          53       53              
  Lines        2797     2797              
==========================================
- Hits         2247     2246       -1     
- Misses        550      551       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Shatur Shatur changed the title Preserve removal before inserts Preserve removals before inserts Apr 15, 2025
Copy link
Collaborator

@UkoeHB UkoeHB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if the server does remove-insert-remove?

@Shatur Shatur merged commit cb9b499 into master Apr 15, 2025
7 checks passed
@Shatur Shatur deleted the preserve-removal-inserts branch April 15, 2025 22:43
@Shatur
Copy link
Contributor Author

Shatur commented Apr 15, 2025

What if the server does remove-insert-remove?

Will be only removed since the component won't exist when we iterate over the world to collect changes. We buffer only removals. Probably worth mentioning things like this somewhere in the docs 🤔

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Component lifecycle not always replicated
2 participants