Resolve all warnings in pytest runs of examples #153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EwoutH
force-pushed
the
resolve-all-warnings
branch
from
879e4ce to
a5e967a
Compare
Resolves 4 warnings by using the AgentSet select(), shuffle() and do() functionality. Also removes the now unused scheduler.
EwoutH
force-pushed
the
resolve-all-warnings
branch
from
a5e967a to
9146f18
Compare
Don't pass the position parameter, but just use place_agent. Resolves the duplicate position warning.
Don't pass the position parameter, but just use place_agent. Resolves the duplicate position warning.
This resolves all warnings outputted by this model. For the model step, the behavior of the old RandomActivationByType scheduler when using step(shuffle_types=True, shuffle_agents=True) is replicated. Conceptually, it can be argued that this should be modelled differently. The verbose prints are also removed.
Don't pass the position parameter, but just use place_agent. Resolves the duplicate position warning.
Uses the -Werror option of pytest to treat warnings as errors. See https://docs.python.org/3/using/cmdline.html#cmdoption-W
Use model.get_agents_of_type instead of model.agents.select() to select all agents of a certain type. It should be faster, since it's a direct dictionary call.
4 tasks
rht
approved these changes
Aug 12, 2024
This was referenced Aug 12, 2024
7 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to resolve all warnings in the current pytest workflow.
select(),shuffle()anddo()functionality.Ready for review! I would especially hear feedback on how the AgentSet is used, and if it can be done more elegantly since these are our examples.
I would like the commits to stay separate, so I would like to merge myself using a fast-forward merge.