Skip to content

fix: Remove JupyterViz grid marker overlap for huge grid size #2049

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Feb 24, 2024

Conversation

rht
Copy link
Contributor

@rht rht commented Feb 22, 2024

Fixes #1741. I have said several times in #1820 that the fix to the overlap problem is simple. I don't want to delay the simple fix for 5 months+ anymore, and so I made this PR.
20x20
20x20
60x60
60x60
100x100
100x100

Copy link

Performance benchmarks:

Model Size Init time [95% CI] Run time [95% CI]
Schelling small 🔵 -0.0% [-0.4%, +0.4%] 🔵 +0.3% [+0.1%, +0.5%]
Schelling large 🔵 +13.2% [-13.9%, +53.9%] 🔵 +0.7% [+0.1%, +1.5%]
WolfSheep small 🔵 +0.2% [-0.2%, +0.6%] 🔵 +0.4% [+0.2%, +0.5%]
WolfSheep large 🔵 +16.5% [-0.3%, +40.7%] 🔵 +0.1% [-0.9%, +1.2%]
BoidFlockers small 🔵 -1.0% [-1.8%, -0.2%] 🔵 -1.0% [-1.8%, -0.4%]
BoidFlockers large 🔵 -1.0% [-1.7%, -0.2%] 🔵 -1.2% [-1.6%, -0.7%]

@Corvince Corvince merged commit 6dbe3e8 into projectmesa:main Feb 24, 2024
@rht rht deleted the jupyterviz_circle branch February 28, 2024 01:39
@EwoutH EwoutH added the bug Release notes label label Apr 18, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Release notes label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JupyterViz: the default grid space drawer doesn't scale to large size
4 participants