Skip to content

add super call to Model and remove self.schedule #2334

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Sep 29, 2024

Conversation

quaquel
Copy link
Member

@quaquel quaquel commented Sep 29, 2024

2 minor cleanups to the Model class

  • explicitly call super so multiple inheritance works correctly
  • remove `self.schedule`` because this is deprecated

@quaquel quaquel added the maintenance Release notes label label Sep 29, 2024
@quaquel quaquel requested a review from EwoutH September 29, 2024 18:34
@quaquel quaquel added trigger-benchmarks Special label that triggers the benchmarking CI and removed trigger-benchmarks Special label that triggers the benchmarking CI labels Sep 29, 2024
Copy link

Performance benchmarks:

Model Size Init time [95% CI] Run time [95% CI]
BoltzmannWealth small 🔵 -1.6% [-2.4%, -0.7%] 🔵 -0.3% [-0.5%, -0.1%]
BoltzmannWealth large 🔵 -1.4% [-1.7%, -1.1%] 🔵 -0.5% [-1.0%, -0.0%]
Schelling small 🔵 -0.6% [-0.9%, -0.3%] 🔵 -0.4% [-0.5%, -0.2%]
Schelling large 🔵 -0.4% [-0.9%, -0.0%] 🔵 -0.0% [-0.9%, +0.8%]
WolfSheep small 🔵 -1.2% [-1.4%, -1.0%] 🔵 -0.3% [-0.5%, -0.2%]
WolfSheep large 🔵 -1.8% [-2.3%, -1.3%] 🔵 -1.7% [-3.2%, -0.0%]
BoidFlockers small 🔵 -1.8% [-2.1%, -1.4%] 🔵 -0.8% [-1.5%, -0.1%]
BoidFlockers large 🔵 -1.5% [-2.2%, -0.7%] 🔵 +0.2% [-0.3%, +0.7%]

@quaquel quaquel merged commit afd3959 into projectmesa:main Sep 29, 2024
11 of 13 checks passed
@quaquel quaquel deleted the model_cleanup branch November 4, 2024 19:37
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
maintenance Release notes label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants